feat: add password change endpoint with complexity validation by kaifcodec · Pull Request #550 · the-momentum/open-wearables

kaifcodec · 2026-03-04T09:40:38Z

This PR implements the backend logic and comprehensive testing for the "Change Password" feature in the Developer Panel. It includes custom validation for password complexity and secure verification of the current password.

Changes Made:

Schema (developer.py):
- Added PasswordChange model.
- Implemented a field_validator to ensure a mix of letters and numbers (min 8 characters).
- Added a model_validator to ensure new_password and confirm_password match.
API Route (auth.py):
- Created POST /change-password endpoint.
- Added logic to verify the user's current_password before permitting changes.
- Integrated with developer_service.update_developer_info to handle automatic password hashing.
Tests (test_auth.py):
- Added TestChangePassword class.
- Added test cases for success, invalid current password, complexity failures, and mismatch errors.

To-Do

Backend: Pydantic Schema validation
Backend: API Route implementation
Backend: Unit tests for authentication logic
Frontend: Create "Change Password" form in React
Frontend: Connect UI to the new API endpoint
Frontend: Add success/error notifications

Closes #531

coderabbitai · 2026-03-04T09:40:49Z

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 2b67b683-9bc4-432b-b874-3355cfddabdf

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

🔍 Trigger review

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests
Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

kaifcodec · 2026-03-04T12:01:09Z

@KaliszS Backend is complete. I'm ready to implement the Change Password UI.
Currently, src/components/settings/ only contains providers/. Should I create a new account/ or security/ directory there for this form?

KaliszS

CI pipeline failed. We need to fix tests and code quality for backend first. Let me know if you need assist with that! :)

Regarding your frontend question, @farce1 should be able to answer this ;)

kaifcodec · 2026-03-08T07:57:37Z

@KaliszS I've addressed the CI failures and the requested changes:

Status Codes: Updated tests to expect 400 instead of 422 to match the project's error handling.
Error Messages: Aligned the mismatch test assertion with the actual API output.
Imports & Style: Fixed the schema export and applied ruff formatting.

I've verified this in a clean environment and all 35 tests in test_auth.py are now passing.

@farce1 Any update on the frontend directory? Should I go ahead with src/components/settings/security/?

The backend is ready for another look!

Gasiek · 2026-03-10T10:19:12Z

Regarding the directory in frontend, you can go ahead with src/components/settings/security/ if security is the idea for the name of the tab for changing the password.

We will anyway need to clean up/restructure the components directory on frontend and settle on one approach where to put what @farce1 . But we will tackle that in a different PR.

KaliszS

There are more things to improve (like JSONResponse in new endpoint with 200/204 status code response or SecretStr instead of str in pydantic model's password fields), but those issue exist in other parts of the same module, so it's something we need to fix in separate PR imho anyway.

backend/app/schemas/developer.py

kaifcodec · 2026-03-11T03:29:05Z

@KaliszS I've pushed the updates to align with your feedback:

Schema Refactor: Removed the password complexity validation. I originally included it to enhance security during the password change flow, but I understand the need for consistency across the platform's current registration logic.

Let me know if there's anything else in the backend that needs adjustment before I move to the frontend.

bartmichalak · 2026-03-11T13:04:09Z

@kaifcodec yes, you can move forward with the frontend changes - whatever needs to be addressed on the backend side, we'll handle separately.

I think a lot of people may need this change, so let's get it done! 😄

KaliszS

From backend side everything is good to go, thanks!

bartmichalak · 2026-03-11T14:19:12Z

@kaifcodec please let us know once it's ready for review (FE part)

kaifcodec · 2026-03-11T14:23:51Z

@bartmichalak Ok, I will let you know. I will just go through the changes once again by myself to look for any issues or mismatches!

kaifcodec · 2026-03-11T14:24:48Z

@bartmichalak Anyways I can already see the CI is failing in FE format check.

kaifcodec · 2026-03-11T14:38:02Z

@bartmichalak I have fixed the frontend formatting.
Review the last 4 commits (The FE part) and let me know if there are any issues that needs to be fixed.

kaifcodec added 2 commits March 4, 2026 14:49

feat: add password change endpoint with complexity validation

ee7ace0

test: add unit tests for change-password endpoint

514ce27

kaifcodec changed the title ~~Feat/password change logic~~ feat: add password change endpoint with complexity validation Mar 4, 2026

KaliszS requested changes Mar 4, 2026

View reviewed changes

kaifcodec added 2 commits March 5, 2026 07:05

fix: export PasswordChange schema from app.schemas

51a12cf

style: apply ruff formatting to auth routes and tests

36da359

kaifcodec requested a review from KaliszS March 5, 2026 01:46

kaifcodec added 2 commits March 5, 2026 15:22

fix(tests): update status codes to 400 for validation

ecb0777

fix(tests): update password mismatch error message to match API output

b62472f

KaliszS requested changes Mar 10, 2026

View reviewed changes

backend/app/schemas/developer.py Outdated Show resolved Hide resolved

refactor: remove password complexity validation for consistency

fef6415

fix: ruff fixes unused import

f9a1051

KaliszS approved these changes Mar 11, 2026

View reviewed changes

kaifcodec added 3 commits March 11, 2026 19:40

feat(api): add change-password endpoint and auth service

b04b7a0

feat(ui): create SecuritySettings component and tab

e48d908

feat(settings): register security tab in settings layout

2f07046

style: fix formatting with prettier

e6d0016

Conversation

kaifcodec commented Mar 4, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Changes Made:

To-Do

Uh oh!

coderabbitai bot commented Mar 4, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Review skipped

Uh oh!

kaifcodec commented Mar 4, 2026

Uh oh!

KaliszS left a comment

Choose a reason for hiding this comment

Uh oh!

kaifcodec commented Mar 8, 2026

Uh oh!

Gasiek commented Mar 10, 2026

Uh oh!

KaliszS left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

kaifcodec commented Mar 11, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

bartmichalak commented Mar 11, 2026

Uh oh!

KaliszS left a comment

Choose a reason for hiding this comment

Uh oh!

bartmichalak commented Mar 11, 2026

Uh oh!

kaifcodec commented Mar 11, 2026

Uh oh!

kaifcodec commented Mar 11, 2026

Uh oh!

kaifcodec commented Mar 11, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

kaifcodec commented Mar 4, 2026 •

edited

Loading

coderabbitai bot commented Mar 4, 2026 •

edited

Loading

kaifcodec commented Mar 11, 2026 •

edited

Loading